Improve const-ness of Net #1686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -89,7 +89,7 @@ class Net { | |||
| * @brief For an already initialized net, implicitly copies (i.e., using no | |||
| * additional memory) the pre-trained layers from another Net. | |||
| */ | |||
| void ShareTrainedLayersWith(Net* other); | |||
| void ShareTrainedLayersWith(Net* other) const; | |||
There was a problem hiding this comment.
This const feels wrong from a logical perspective. It clearly modifies the current network.
There was a problem hiding this comment.
Oops, I was thinking this went the other way, thanks for pointing that out. I guess there is some subtle reason why the compiler does not generate any warnings in this case. I'll push a corrected version shortly...
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Netcurrently has a somewhat lackluster use ofconst. Returned references should beconst; it's not okay to modify the referents. Accessors and some other functions can beconstmethods; it is okay to call them onconst Nets.A few changes need to be made to fix existing code. In particular
std::map::operator[]is not aconstmethod, so the somewhat more obscurefind(...)->secondneeds to be used instead in a couple places.(I need a few of these for a future PR, so I went ahead and took a pass over the whole
Netinterface.)If you find any of this
constness too intrusive, discuss.