Max out the protobuf file read size limit #1756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, I've run into this before. Perhaps we should make this less mysterious by using |
jeffdonahue
force-pushed
the
max-total-bytes-limit
branch
from
33ece7c
to
db89777
Compare
|
yup, good idea, fixed |
| @@ -17,6 +17,8 @@ | |||
| #include "caffe/proto/caffe.pb.h" | |||
| #include "caffe/util/io.hpp" | |||
|
|
|||
| #define kProtoReadBytesLimit INT_MAX // Max size of 2 GB minus 1 byte. | |||
There was a problem hiding this comment.
Since this is C++, why not const int?
jeffdonahue
force-pushed
the
max-total-bytes-limit
branch
from
db89777
to
60f26d6
Compare
longjon
added a commit
that referenced
this pull request
Jan 20, 2015
Max out the protobuf file read size limit
|
Look good, merged. It would be nice to also break out the other mysterious constant at some point... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets the max possible size of protobuf reads to 2 GB minus 1 byte (= 2^31 - 1), the largest
intvalue. (If we want to start supporting nets with total param size >= 2 GB this we'll have to come up with a new solution. For example, we could store each parameter in a separate binary proto file, or switch to HDF5 for parameter serialization.)