Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide a solver option to limit runtime (max_seconds) #1956

Closed
wants to merge 1 commit into from

Conversation

jsupancic
Copy link
Contributor

This is an updated version of PR #1925 which should pass the lint checks . For some reason I cannot reopen a PR after force pushing, but can force push to an open PR? Strange behavior to keep in mind. Ref. isaacs/github#361

This patch lets you say "run for 12 hours = 43200 seconds".
It's useful when you need exact limits with shared computing resources.
The runtime limit is enabled by setting max_seconds to a value > 0.
Maybe it helps?

Best,
James

@jsupancic
Copy link
Contributor Author

Heads up, I accidentally targeted the master branch when I meant the dev branch. Sorry, I'm still learning github. :-/

Can this be fixed without creating a new PR?

Best,
James

@shelhamer
Copy link
Member

No no! master is right as of the last release. All development is now off
master. I'll make a further post to the mailing list to try and clarify
this.

Thanks for the cleaned up contribution.
On Tue, Feb 24, 2015 at 16:33 James Steven Supancic III <
notifications@github.com> wrote:

Heads up, I accidentally targeted the master branch when I meant the dev
branch. Sorry, I'm still getting the hand of github. :-/

Best,
James


Reply to this email directly or view it on GitHub
#1956 (comment).

@longjon
Copy link
Contributor

longjon commented Feb 25, 2015

This seems sort of reasonable and convenient, but I'm not sure I see why this should be a feature of Caffe instead of something handled externally. Do the other devs think the clutter is worth the convenience?

(Also, what happens if you set max_seconds and then change your mind and want to keep running? If some external process is responsible for halting Caffe, you may still be able to do that. With this patch, too bad.)

(A related question: should Caffe attempt to snapshot on SIGINT?)

@shelhamer
Copy link
Member

On further thought I agree with @longjon. I too can see the convenience but this seems like a responsibility better left to the caller / cluster. Thanks for sending the code all the same @jsupancic so users who want it can merge it. Let's close this but comment if there is an overwhelming reason this should be part of the framework itself.

See #2012 for the snapshot on signal idea.

@shelhamer shelhamer closed this Mar 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants