Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSX 10.10 (and more) use Accelerate Framework instead of veclib #3272

Merged
merged 1 commit into from
Aug 18, 2016

Conversation

ixartz
Copy link
Contributor

@ixartz ixartz commented Nov 3, 2015

OSX Yosemite 10.10 (and more) use Accelerate Framework instead of veclib.
In Accelerate Framework, cblas.h does not exist and we need to include Accelerate/Accelerate.h

@ixartz ixartz force-pushed the master branch 2 times, most recently from 7eaf553 to dd33d18 Compare November 3, 2015 04:51
@@ -23,7 +23,7 @@ apt-get install \
# Caffe requires a minimum CMake version of 2.8.8.
if $WITH_CMAKE; then
# cmake 3 will make sure that the python interpreter and libraries match
wget http://www.cmake.org/files/v3.2/cmake-3.2.3-Linux-x86_64.sh -O cmake3.sh
wget --no-check-certificate http://www.cmake.org/files/v3.2/cmake-3.2.3-Linux-x86_64.sh -O cmake3.sh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merged in #3276.

@ixartz
Copy link
Contributor Author

ixartz commented Nov 11, 2015

Update the pull request after merging wget cmake with --no-check-certificate

@Duffycola
Copy link

Duffycola commented Jun 30, 2016

This problem has reappeared in OS X El Capitan 10.11.5 (15F34), where vecLib has moved from the standard location into the Accelerate framework.

This commit, however, does not work on the cmake side, because the vecLib.h files still exist:

$ cat /System/Library/Frameworks/vecLib.framework/Headers/vecLib.h
#error "The vecLib framework is deprecated. Please include <Accelerate/Accelerate.h> instead of <vecLib/vecLib.h> and link to the Accelerate framework instead of the vecLib framework."

I think this commit goes in the right direction, but is now a bit outdated. Also the fix should happen in cmake/Modules/FindvecLib.cmake

@shelhamer shelhamer merged commit 4572501 into BVLC:master Aug 18, 2016
@shelhamer
Copy link
Member

Thanks for the improved OS X build logic @ixartz. I agree with @Duffycola that this could still be an issue due to the deprecated vecLib.h. A further patch along the lines of #4247 (comment) might be needed to make this work correctly.

If anybody on OS X wants to follow-up with a patch for that (potentially simplifying the just-merged #4247), please do.

p.s. FWIW the Makefile build seems to be compatible with El Cap.

fxbit pushed a commit to Yodigram/caffe that referenced this pull request Sep 1, 2016
[cmake] OSX 10.10 (and more) use Accelerate Framework instead of veclib
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants