-
Notifications
You must be signed in to change notification settings - Fork 18.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSX 10.10 (and more) use Accelerate Framework instead of veclib #3272
Conversation
7eaf553
to
dd33d18
Compare
@@ -23,7 +23,7 @@ apt-get install \ | |||
# Caffe requires a minimum CMake version of 2.8.8. | |||
if $WITH_CMAKE; then | |||
# cmake 3 will make sure that the python interpreter and libraries match | |||
wget http://www.cmake.org/files/v3.2/cmake-3.2.3-Linux-x86_64.sh -O cmake3.sh | |||
wget --no-check-certificate http://www.cmake.org/files/v3.2/cmake-3.2.3-Linux-x86_64.sh -O cmake3.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This belongs in a separate commit, but I can verify that it's needed.
https://travis-ci.org/BVLC/caffe/jobs/88939834
https://travis-ci.org/BVLC/caffe/jobs/89066109
https://travis-ci.org/NVIDIA/caffe/jobs/89073960
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merged in #3276.
Update the pull request after merging wget cmake with --no-check-certificate |
This problem has reappeared in OS X El Capitan 10.11.5 (15F34), where vecLib has moved from the standard location into the Accelerate framework. This commit, however, does not work on the cmake side, because the vecLib.h files still exist:
I think this commit goes in the right direction, but is now a bit outdated. Also the fix should happen in cmake/Modules/FindvecLib.cmake |
Thanks for the improved OS X build logic @ixartz. I agree with @Duffycola that this could still be an issue due to the deprecated If anybody on OS X wants to follow-up with a patch for that (potentially simplifying the just-merged #4247), please do. p.s. FWIW the Makefile build seems to be compatible with El Cap. |
[cmake] OSX 10.10 (and more) use Accelerate Framework instead of veclib
OSX Yosemite 10.10 (and more) use Accelerate Framework instead of veclib.
In Accelerate Framework, cblas.h does not exist and we need to include Accelerate/Accelerate.h