Dismantle Layer Headers #3315
Merged
Dismantle Layer Headers #3315
+4,497
−3,568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shelhamer
force-pushed
the
layer-headers
branch
from
a6947a8 to
d97cb19
Compare
Even with this, it is greatly welcomed PR :) |
shelhamer
force-pushed
the
layer-headers
branch
2 times, most recently
from
c13b2f2 to
69d7aa6
Compare
|
@ronghanghu can I ask for your help to check if this is compatible with matcaffe? |
|
@shelhamer Of course! I am checking. |
|
All matcaffe tests passed with this PR on a BVLC machine. |
shelhamer
force-pushed
the
layer-headers
branch
from
69d7aa6 to
242e422
Compare
shelhamer
force-pushed
the
layer-headers
branch
2 times, most recently
from
479906c to
7a234e0
Compare
No more monolithic includes: split layers into their own headers for modular inclusion and build.
shelhamer
force-pushed
the
layer-headers
branch
from
7a234e0 to
300f43f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Monolithic layer includes trigger grossly unnecessary recompilation whenever a change is made to even a single layer definition. Dismantling the agglomerated
vision_layer.hpp,common_layers.hpp, and so forth makes the dependencies and build more modular. This should likewise reduce conflicts in layer development and PRs.Regarding dependencies, I do not promise that this PR is free of recursive includes. Occasionally a
make cleanmight be needed (if this is in fact a problem at all; I need to review dependency generation...) but this is no different than the current arrangement.I admit there is essentially never a good time for this PR since it will impact any layers in progress but at some point the headers need breaking for mending.
To reconcile your own branches with this you should rebase and transplant changes to the monolithic headers to the relevant layer header (which you need to create for your own layers).
Now the only obstacle to decoupled layer development is the common caffe.proto.