updating creating user from byu since we already have a function that…

… does that.
BYU-ODH · Oct 17, 2024 · feda9cc · feda9cc
1 parent 9371639
commit feda9cc
Showing 1 changed file with 10 additions and 9 deletions.
diff --git a/src/clj/y_video_back/routes/service_handlers/handlers/user_handlers.clj b/src/clj/y_video_back/routes/service_handlers/handlers/user_handlers.clj
@@ -37,17 +37,18 @@
   "given `username` netid, when the user is new, query for their BYU data and use it to return a constructed new user"
   ;; [username byu-person-id]
   [username]
-  (let [yvideo-user-exists? (not-empty (users/READ-BY-USERNAME username))
+  (let [yvideo-user-exists? (not-empty (users/READ-BY-USERNAME username))]
+        (when-not yvideo-user-exists? (uc/create-potentially-empty-user username)))) ;; handles creating user if doesn't exist already
         ;; will have to user BYU id (byu-person-id) when calling with the new bdp
         ;; byu-data (when-not yvideo-user-exists? (persons/get-user-data-new byu-person-id))
-        byu-data (when-not yvideo-user-exists? (uc/create-potentially-empty-user username))
-        nominal-user-data  (when-let [d byu-data] {:username username
-                                                   :account-name (:full-name d)
-                                                   :account-type (int (:account-type d)) ;; magic numbers 🙍
-                                                   :email (:email d)})] 
-    (when-not yvideo-user-exists?
-      {:db-item (users/CREATE nominal-user-data)
-       :user-data nominal-user-data})))
+    ;;     byu-data (when-not yvideo-user-exists? (uc/create-potentially-empty-user username))
+    ;;     nominal-user-data  (when-let [d byu-data] {:username username
+    ;;                                                :account-name (:full-name d)
+    ;;                                                :account-type (int (:account-type d)) ;; magic numbers 🙍
+    ;;                                                :email (:email d)})] 
+    ;; (when-not yvideo-user-exists?
+    ;;   {:db-item (users/CREATE nominal-user-data)
+    ;;    :user-data nominal-user-data})))
 
 ;; this is NOT where the user is set up via CAS. This code generates a user given an netid. The netId is maybe provided by CAS from somewhere else, but most likely it is provided by an admin user.
 (def user-create-from-byu