Fix macos not building with cpp 14 compat #744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ayaka14732 , I created a build job that does everything that the release to pypi job does, without pushing the wheel to pypi and tested that. Both the macos-11 and macos-12 images seem to build fine. This should fix the build issue with macos. |
ayaka14732
approved these changes
Dec 6, 2022
|
Thanks @ayaka14732 . I'm not sure what the protocol is here. My understanding is that you should now just be able to run the release job and, if the compile gods smile, it should redeploy correctly. It might fail to push to windows and Linux (I might be remembering wrong though) but should succeed to Mac, and that is what we are after anyway. If you want a version bump then let me know and I'll do that first thing tomorrow |
|
I am going to run the release job again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #743
From my testing this forces both the macos-11 and macos-12 github build images to use the proper compatibility, and builds all wheels for mac successfully.