Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NME] Prevent alt+click shortcut to drop elbow on complex node connections #12354

Closed
PatrickRyanMS opened this issue Apr 6, 2022 · 0 comments
Assignees
Labels
bug nme Node Material Editor
Milestone

Comments

@PatrickRyanMS
Copy link
Member

Elbows cannot handle complex node connections like those between ImageAssetBlock and TetxtureBlock

image

If the user tries to drop an elbow on a connection between complex nodes, the elbow will place with no connections. Going forward any elbow dropped with the shortcut on any connection will fail and only place an unconnected elbow.

Repro

  • Bug repro on NME Sample:
  • alt + click on the blue connection between ImageAssetBlock and TextureBlock
  • note that the elbow is not connected to anything
  • next try to alt + click on any other connection, either the Vector2 or Float connections. Note that the elbow also drops unconnected and now the shortcut does not work anymore.

It would be best if we disallow the shortcut to create an elbow if the user is hovering a connection that is not allowed by the elbow. I assume that eliminating this as an option to create an elbow will avoid the state that breaks the shortcut after trying to add an elbow on a complex node connection.

@PatrickRyanMS PatrickRyanMS added bug nme Node Material Editor labels Apr 6, 2022
@PatrickRyanMS PatrickRyanMS added this to the 6.0 milestone Apr 6, 2022
deltakosh added a commit that referenced this issue Apr 7, 2022
deltakosh added a commit that referenced this issue Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug nme Node Material Editor
Projects
None yet
Development

No branches or pull requests

3 participants