Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing es6 import error messages #5913

Closed
TrevorDev opened this issue Feb 13, 2019 · 1 comment
Closed

Missing es6 import error messages #5913

TrevorDev opened this issue Feb 13, 2019 · 1 comment
Assignees
@TrevorDev
Labels
bug
Milestone
4.0

Comments

@TrevorDev
Copy link
Contributor

https://forum.babylonjs.com/t/es6-tree-shaking-experience/1365/2
@TrevorDev TrevorDev added the bug label Feb 13, 2019
@TrevorDev TrevorDev added this to the 4.0 milestone Feb 13, 2019
@TrevorDev TrevorDev self-assigned this Feb 13, 2019
@sebavan
Copy link
Member

sebavan commented Feb 13, 2019

About some of them I guess the import is missing or the code should be reviewed to not have the message like defaultRenderingPipeline could import postProcessRenderPipelineManagerScene That said we need to prevent circular dependencies.

Let s be careful on this one to make it as natural as possible :-)

@TrevorDev TrevorDev mentioned this issue Feb 13, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TrevorDev TrevorDev

Labels
bug
Projects
None yet
Milestone
4.0
Development

No branches or pull requests
3 participants
@deltakosh @TrevorDev @sebavan