Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add required es6 includes #5918

Merged
merged 1 commit into from
Feb 14, 2019
Merged

add required es6 includes #5918

merged 1 commit into from
Feb 14, 2019

Conversation

TrevorDev
Copy link
Contributor

sebavan
sebavan reviewed Feb 13, 2019
View reviewed changes
src/Layers/glowLayer.ts
@@ -21,6 +21,7 @@ import { _TypeStore } from '../Misc/typeStore';

import "../Shaders/glowMapMerge.fragment";
import "../Shaders/glowMapMerge.vertex";
import "../Layers/effectLayerSceneComponent";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it not creating a circular ref ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gulp circularDependencies didnt fail

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Swweeeeet perfect then

@deltakosh deltakosh merged commit b5daa5e into BabylonJS:master Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebavan sebavan sebavan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TrevorDev @sebavan @deltakosh