Data Buffer Memory allocation And KHR_materials_emissive_strength cause I pushed it all... #11345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebavan
changed the title
|
Fix #11345 |
Popov72
approved these changes
Oct 27, 2021
|
I'm asking for a sample model. Should we add a validation test for this? |
bghgary
approved these changes
Oct 27, 2021
loaders/src/glTF/2.0/Extensions/KHR_materials_emissive_strength.ts
Outdated
Show resolved
Hide resolved
loaders/src/glTF/2.0/Extensions/KHR_materials_emissive_strength.ts
Outdated
Show resolved
Hide resolved
Yup I locally modified the boom box but would prefer the test based on their model so I ll add the validation test as soon as we have the model |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.