Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deletion of descendant controls in the gui editor #12271

Merged
merged 4 commits into from
Mar 31, 2022
Merged

Fix deletion of descendant controls in the gui editor #12271

merged 4 commits into from
Mar 31, 2022

Conversation

carolhmj
Copy link
Contributor

Without this change, deleting a button, for example, would only delete it on the live texture but not on the linked GUI editor

@carolhmj carolhmj requested a review from darraghjburke March 28, 2022 16:53
@azure-pipelines
Copy link

Snapshot stored with reference name:
refs/pull/12271/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12271/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12271/merge/index.html#WGZLGJ#4600

To test the snapshot in the playground itself use (for example):

https://playground.babylonjs.com/?snapshot=refs/pull/12271/merge#BCU1XR#0

darraghjburke
darraghjburke reviewed Mar 28, 2022
View reviewed changes
Copy link
Contributor

@darraghjburke darraghjburke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one question!

packages/tools/guiEditor/src/globalState.ts Show resolved Hide resolved
@azure-pipelines
Copy link

We have noticed you haven't changes the "what's new.md" file. If your update is important (a bug fix, a new feature), please make sure to update the what's new file in the base directory and commit the changes.

@azure-pipelines
Copy link

Snapshot stored with reference name:
refs/pull/12271/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12271/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12271/merge/index.html#WGZLGJ#4600

To test the snapshot in the playground itself use (for example):

https://playground.babylonjs.com/?snapshot=refs/pull/12271/merge#BCU1XR#0

@RaananW RaananW enabled auto-merge (squash) March 31, 2022 13:24
@azure-pipelines
Copy link

We have noticed you haven't changes the "what's new.md" file. If your update is important (a bug fix, a new feature), please make sure to update the what's new file in the base directory and commit the changes.

@azure-pipelines
Copy link

Snapshot stored with reference name:
refs/pull/12271/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12271/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12271/merge/index.html#WGZLGJ#4600

To test the snapshot in the playground itself use (for example):

https://playground.babylonjs.com/?snapshot=refs/pull/12271/merge#BCU1XR#0

@RaananW RaananW merged commit dd2eb63 into BabylonJS:master Mar 31, 2022
@carolhmj carolhmj deleted the geFixDeletionOfDescendants branch March 31, 2022 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darraghjburke darraghjburke darraghjburke left review comments

@RaananW RaananW RaananW approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carolhmj @darraghjburke @RaananW