Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a new flag for checking double sided mesh in collision #12318

Merged
merged 2 commits into from
Apr 1, 2022
Merged

Added a new flag for checking double sided mesh in collision #12318

merged 2 commits into from
Apr 1, 2022

Conversation

CedricGuillemet
Copy link
Contributor

Added a new flag for checking double sided mesh in collision detection (disable by default)

follow up https://forum.babylonjs.com/t/movewithcollisions-cant-handle-doublesided-meshes/28928
double sided face are evaluated 2 times, by design. With this change, they are only evaluated once.
To not break back compat, it's hidden behind a flag.
To enable it :

BABYLON.Collider.DoubleSidedCheck = true;

@azure-pipelines
Copy link

We have noticed you haven't changes the "what's new.md" file. If your update is important (a bug fix, a new feature), please make sure to update the what's new file in the base directory and commit the changes.

@azure-pipelines
Copy link

Snapshot stored with reference name:
refs/pull/12318/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12318/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12318/merge/index.html#WGZLGJ#4600

To test the snapshot in the playground itself use (for example):

https://playground.babylonjs.com/?snapshot=refs/pull/12318/merge#BCU1XR#0

@azure-pipelines
Copy link

We have noticed you haven't changes the "what's new.md" file. If your update is important (a bug fix, a new feature), please make sure to update the what's new file in the base directory and commit the changes.

@azure-pipelines
Copy link

Snapshot stored with reference name:
refs/pull/12318/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12318/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12318/merge/index.html#WGZLGJ#4600

To test the snapshot in the playground itself use (for example):

https://playground.babylonjs.com/?snapshot=refs/pull/12318/merge#BCU1XR#0

@RaananW
Copy link
Member

RaananW commented Apr 1, 2022

we'll need to document that as well :-)

@RaananW RaananW merged commit 92a690d into BabylonJS:master Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants