Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#12204 Add limit to auto rotate #12429

Merged
merged 4 commits into from
Apr 26, 2022

Conversation

TheCrowd
Copy link
Contributor

add targetAlpha to autoRotateBehavior to serve as a limit. When the limit is reached, the autoRotateBehavoir would stop.

@azure-pipelines
Copy link

Please make sure to tag your PR with "bug", "new feature" or "breaking change" tags.

@azure-pipelines
Copy link

Snapshot stored with reference name:
refs/pull/12429/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12429/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12429/merge/index.html#WGZLGJ#4600

To test the snapshot in the playground itself use (for example):

https://playground.babylonjs.com/?snapshot=refs/pull/12429/merge#BCU1XR#0

Copy link
Member

@RaananW RaananW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for this PR!

There are a few comments I added. You also need to allow the user to disable this feature, so make sure the targetAlpha is not only a number, but optionally null (which should be the default value)

@azure-pipelines
Copy link

Please make sure to tag your PR with "bug", "new feature" or "breaking change" tags.

@azure-pipelines
Copy link

Please make sure to tag your PR with "bug", "new feature" or "breaking change" tags.

@azure-pipelines
Copy link

@deltakosh deltakosh enabled auto-merge (squash) April 26, 2022 15:06
@deltakosh deltakosh merged commit 2373fb4 into BabylonJS:master Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants