-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#12204 Add limit to auto rotate #12429
#12204 Add limit to auto rotate #12429
Conversation
Please make sure to tag your PR with "bug", "new feature" or "breaking change" tags. |
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12429/merge/index.html#WGZLGJ#4600 To test the snapshot in the playground itself use (for example): https://playground.babylonjs.com/?snapshot=refs/pull/12429/merge#BCU1XR#0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for this PR!
There are a few comments I added. You also need to allow the user to disable this feature, so make sure the targetAlpha
is not only a number, but optionally null
(which should be the default value)
packages/dev/core/src/Behaviors/Cameras/autoRotationBehavior.ts
Outdated
Show resolved
Hide resolved
packages/dev/core/src/Behaviors/Cameras/autoRotationBehavior.ts
Outdated
Show resolved
Hide resolved
Please make sure to tag your PR with "bug", "new feature" or "breaking change" tags. |
packages/dev/core/src/Behaviors/Cameras/autoRotationBehavior.ts
Outdated
Show resolved
Hide resolved
packages/dev/core/src/Behaviors/Cameras/autoRotationBehavior.ts
Outdated
Show resolved
Hide resolved
Please make sure to tag your PR with "bug", "new feature" or "breaking change" tags. |
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12429/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/12429/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/12429/merge#BCU1XR#0 |
add
targetAlpha
to autoRotateBehavior to serve as a limit. When the limit is reached, the autoRotateBehavoir would stop.