Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix iridescence texture transform #12432

Merged
merged 2 commits into from
Apr 25, 2022
Merged

Fix iridescence texture transform #12432

merged 2 commits into from
Apr 25, 2022

Conversation

sebavan
Copy link
Member

@sebavan sebavan commented Apr 24, 2022

Fix #12431

@azure-pipelines
Copy link

Please make sure to tag your PR with "bug", "new feature" or "breaking change" tags.

@azure-pipelines
Copy link

Snapshot stored with reference name:
refs/pull/12432/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12432/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12432/merge/index.html#WGZLGJ#4600

To test the snapshot in the playground itself use (for example):

https://playground.babylonjs.com/?snapshot=refs/pull/12432/merge#BCU1XR#0

@azure-pipelines
Copy link

Visualization tests for webgl2 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12432/merge/testResults/webgl2/index.html

If tests were successful afterwards, this report might not be available anymore.

@sebavan sebavan requested a review from RaananW April 25, 2022 17:03
@deltakosh deltakosh merged commit d3b4fa9 into BabylonJS:master Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KHR_materials_iridescence incompatible with KHR_texture_transform
2 participants