Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ubo not of the right size when using material plugins #12502

Merged
merged 2 commits into from
May 9, 2022
Merged

Fix ubo not of the right size when using material plugins #12502

merged 2 commits into from
May 9, 2022

Conversation

Popov72
Copy link
Contributor

@Popov72 Popov72 commented May 9, 2022

See https://forum.babylonjs.com/t/pluginmaterial-bug/30098

To fix the problem I simply generate a specific #define for each plugin and use this define in the vertex/fragment shaders when the plugin is used.

I have also added a visualization test to test this case.

@deltakosh
Copy link
Contributor

you rock!

@deltakosh deltakosh requested a review from sebavan May 9, 2022 15:31
@azure-pipelines
Copy link

Please make sure to tag your PR with "bug", "new feature" or "breaking change" tags.

@azure-pipelines
Copy link

Please make sure to tag your PR with "bug", "new feature" or "breaking change" tags.

@azure-pipelines
Copy link

@RaananW RaananW added the bug label May 9, 2022
@RaananW RaananW merged commit c09a523 into BabylonJS:master May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants