Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate gltf 1.0 modules #12648

Merged
merged 2 commits into from
Jun 14, 2022
Merged

deprecate gltf 1.0 modules #12648

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c89837f
deprecate gltf1.0 modules
RaananW Jun 13, 2022
684cd15
formatting
RaananW Jun 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/dev/loaders/src/glTF/1.0/glTFBinaryExtension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,10 @@ interface IGLTFBinaryExtensionImage {
width: number;
}

/** @hidden */
/**
* @hidden
* @deprecated
*/
export class GLTFBinaryExtension extends GLTFLoaderExtension {
private _bin: IDataBuffer;

Expand Down
1 change: 1 addition & 0 deletions packages/dev/loaders/src/glTF/1.0/glTFLoader.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1743,6 +1743,7 @@ export class GLTFLoaderBase {
/**
* glTF V1 Loader
* @hidden
* @deprecated
*/
export class GLTFLoader implements IGLTFLoader {
public static Extensions: { [name: string]: GLTFLoaderExtension } = {};
Expand Down
1 change: 1 addition & 0 deletions packages/dev/loaders/src/glTF/1.0/glTFLoaderUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import type { Scene } from "core/scene";
/**
* Utils functions for GLTF
* @hidden
* @deprecated
*/
export class GLTFUtils {
/**
Expand Down
5 changes: 4 additions & 1 deletion packages/dev/loaders/src/glTF/1.0/glTFMaterialsCommonExtension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,10 @@ interface IGLTFSpotLightCommonExtension {
quadraticAttenuation: number;
}

/** @hidden */
/**
* @hidden
* @deprecated
*/
export class GLTFMaterialsCommonExtension extends GLTFLoaderExtension {
constructor() {
super("KHR_materials_common");
Expand Down