Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deletion of Grid items in Editor, also fix... #12653

Merged
merged 2 commits into from
Jun 14, 2022
Merged

Fix deletion of Grid items in Editor, also fix... #12653

merged 2 commits into from
Jun 14, 2022

Conversation

carolhmj
Copy link
Contributor

the width of the button panel, and fix an exception that was being thrown when changing the grid row/column of a grid element.

Related playground: https://playground.babylonjs.com/#9FW40S

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

@azure-pipelines
Copy link

Visualization tests for webgl1 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12653/merge/testResults/webgl1/index.html

If tests were successful afterwards, this report might not be available anymore.

@sebavan sebavan enabled auto-merge June 14, 2022 19:54
@sebavan sebavan merged commit 229ab36 into BabylonJS:master Jun 14, 2022
@carolhmj carolhmj deleted the GE-fix-deletion-grid branch June 15, 2022 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants