Inspectable options fix #12669
Inspectable options fix #12669
Conversation
previously could only supply an empty array or undefined to the options property of an instance of type IInspectable
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
There is no need to update the "what's new.md" file. A changelog will be generated using the PR and its tags. |
This reverts commit e505ab1.
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12669/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/12669/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/12669/merge#BCU1XR#0 |
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12669/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/12669/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/12669/merge#BCU1XR#0 |
Custom inspectables could not be provided with an appropriate options array as the type was either undefined or empty array, this way it can be undefined or an array of IInspectableOptions
Here is an example of being forced to use "as any" with current babylonjs in typescript when using the custom inspectable type options, when removing the "as any" this will break:
https://playground.babylonjs.com/#LTH16U
Here is an example with the snapshot where we aren't forced to use "as any":
https://playground.babylonjs.com/?snapshot=refs/pull/12669/merge#TCE5N9