Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix node decomposing at drop time #12698

Merged
merged 2 commits into from
Jun 30, 2022
Merged

Fix node decomposing at drop time #12698

merged 2 commits into from
Jun 30, 2022

Conversation

deltakosh
Copy link
Contributor

No description provided.

@deltakosh deltakosh requested a review from sebavan June 30, 2022 15:16
@deltakosh deltakosh enabled auto-merge (squash) June 30, 2022 15:16
@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

Snapshot stored with reference name:
refs/pull/12698/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12698/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12698/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/12698/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/12698/merge
https://gui.babylonjs.com/?snapshot=refs/pull/12698/merge
https://nme.babylonjs.com/?snapshot=refs/pull/12698/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/12698/merge#BCU1XR#0

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

Snapshot stored with reference name:
refs/pull/12698/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12698/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12698/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/12698/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/12698/merge
https://gui.babylonjs.com/?snapshot=refs/pull/12698/merge
https://nme.babylonjs.com/?snapshot=refs/pull/12698/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/12698/merge#BCU1XR#0

@deltakosh deltakosh merged commit 5b1b729 into master Jun 30, 2022
@deltakosh deltakosh deleted the Fix-node-decomposing-at-drop-time branch June 30, 2022 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebavan sebavan sebavan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deltakosh @sebavan