Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically change hardware scaling based on browser zoom level #12737

Merged
merged 1 commit into from
Jul 12, 2022
Merged

Automatically change hardware scaling based on browser zoom level #12737

merged 1 commit into from
Jul 12, 2022

Conversation

RaananW
Copy link
Member

@RaananW RaananW commented Jul 12, 2022

Fixes #12711
This does 2 things:

  1. If adapt to device ratio is turned on we are using the delta between the last recorded device pixel ratio and the current one to change the hardware scaling rate.
  2. adaptToDeviceRatio is not public and can be changed not only in the constructor.

@RaananW
Automatically change hardware scaling based on browser zoom level
fb32d62 
Fixes #12711
This does 2 things:
1) If adapt to device ratio is turned on we are using the delta between the last recorded device pixel ratio and the current one to change the hardware scaling rate.
2) adaptToDeviceRatio is not public and can be changed not only in the constructor.
@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

Snapshot stored with reference name:
refs/pull/12737/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12737/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12737/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/12737/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/12737/merge
https://gui.babylonjs.com/?snapshot=refs/pull/12737/merge
https://nme.babylonjs.com/?snapshot=refs/pull/12737/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/12737/merge#BCU1XR#0

@deltakosh deltakosh enabled auto-merge (squash) July 12, 2022 16:02
@deltakosh deltakosh merged commit 63a3059 into BabylonJS:master Jul 12, 2022
@RaananW RaananW deleted the RaananW/issue12711 branch July 12, 2022 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deltakosh deltakosh deltakosh approved these changes

Assignees
No one assigned
Labels
new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Automatically change hardware scaling based on browser zoom level
2 participants
@RaananW @deltakosh