Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

toolbar can expand now #12755

Merged
merged 7 commits into from
Jul 19, 2022
Merged

toolbar can expand now #12755

merged 7 commits into from
Jul 19, 2022

Conversation

amritanarasimhan
Copy link
Contributor

No previous functionality for expanding toolbar on smaller screens (scroll only)

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

Snapshot stored with reference name:
refs/pull/12755/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12755/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12755/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/12755/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/12755/merge
https://gui.babylonjs.com/?snapshot=refs/pull/12755/merge
https://nme.babylonjs.com/?snapshot=refs/pull/12755/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/12755/merge#BCU1XR#0

@sebavan sebavan requested a review from RaananW July 18, 2022 11:46
RaananW
RaananW requested changes Jul 18, 2022
View reviewed changes
Copy link
Member

@RaananW RaananW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most (if not all) of my comments are about code reusability. There is a lot of code that is repeating and can be adjusted and removed.

packages/tools/guiEditor/src/workbenchEditor.tsx Outdated Show resolved Hide resolved
packages/tools/guiEditor/src/workbenchEditor.tsx Outdated Show resolved Hide resolved
packages/tools/guiEditor/src/controlTypes.ts Outdated Show resolved Hide resolved
packages/tools/guiEditor/src/controlTypes.ts Outdated Show resolved Hide resolved
packages/tools/guiEditor/src/main.scss Outdated Show resolved Hide resolved
@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

Snapshot stored with reference name:
refs/pull/12755/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12755/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12755/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/12755/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/12755/merge
https://gui.babylonjs.com/?snapshot=refs/pull/12755/merge
https://nme.babylonjs.com/?snapshot=refs/pull/12755/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/12755/merge#BCU1XR#0

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

Snapshot stored with reference name:
refs/pull/12755/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12755/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12755/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/12755/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/12755/merge
https://gui.babylonjs.com/?snapshot=refs/pull/12755/merge
https://nme.babylonjs.com/?snapshot=refs/pull/12755/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/12755/merge#BCU1XR#0

@RaananW RaananW enabled auto-merge (squash) July 19, 2022 16:26
@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

Snapshot stored with reference name:
refs/pull/12755/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12755/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12755/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/12755/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/12755/merge
https://gui.babylonjs.com/?snapshot=refs/pull/12755/merge
https://nme.babylonjs.com/?snapshot=refs/pull/12755/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/12755/merge#BCU1XR#0

@RaananW RaananW merged commit 7899cf7 into BabylonJS:master Jul 19, 2022
RaananW pushed a commit that referenced this pull request Dec 9, 2022
@amritanarasimhan
toolbar can expand now (#12755)
fadc5a5 
* toolbar can expand now

* fixed formatting

* forgot to add relevant file

* Reduced some code redundancy

* formatting

* fixed redundant code in createToolbar

* fixed uneven elements layout

Former-commit-id: 9363544a08edd6dbadfd5a8cfeb5c8be4481e186
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaananW RaananW RaananW approved these changes

Assignees
No one assigned
Labels
new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amritanarasimhan @RaananW