Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Native readPixels implementation #12768

Merged
merged 5 commits into from
Jul 20, 2022
Merged

Native readPixels implementation #12768

merged 5 commits into from
Jul 20, 2022

Conversation

ryantrem
Copy link
Member

This change provides a native implementation for reading a texture to obtain an rbga8 buffer. It does not currently support cube maps.

See the corresponding Babylon Native change here: BabylonJS/BabylonNative#1104

@ryantrem ryantrem mentioned this pull request Jul 19, 2022
Merged
@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

Snapshot stored with reference name:
refs/pull/12768/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12768/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12768/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/12768/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/12768/merge
https://gui.babylonjs.com/?snapshot=refs/pull/12768/merge
https://nme.babylonjs.com/?snapshot=refs/pull/12768/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/12768/merge#BCU1XR#0

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

Snapshot stored with reference name:
refs/pull/12768/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12768/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12768/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/12768/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/12768/merge
https://gui.babylonjs.com/?snapshot=refs/pull/12768/merge
https://nme.babylonjs.com/?snapshot=refs/pull/12768/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/12768/merge#BCU1XR#0

@ryantrem ryantrem marked this pull request as ready for review July 20, 2022 22:00
@bghgary bghgary merged commit da11561 into BabylonJS:master Jul 20, 2022
RaananW pushed a commit that referenced this pull request Dec 9, 2022
@ryantrem
Native readPixels implementation (#12768)
f255150 
Former-commit-id: 84150ddf971f64d47e3476a206532e0c4fae9b8b
@ryantrem ryantrem deleted the native-reax-pixels branch July 1, 2024 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bghgary bghgary bghgary approved these changes

@SergioRZMasson SergioRZMasson Awaiting requested review from SergioRZMasson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryantrem @bghgary