Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add computeBoundingBox as a constructor option on SPS. #12778

Merged
merged 1 commit into from
Jul 21, 2022
Merged

Add computeBoundingBox as a constructor option on SPS. #12778

merged 1 commit into from
Jul 21, 2022

Conversation

carolhmj
Copy link
Contributor

Closes #11892

There was already support for setting the bounding box size as the SPS size on the code, but there wasn't an option to enable this on the constructor.

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

@sebavan sebavan requested a review from RaananW July 21, 2022 16:51
@sebavan sebavan merged commit 09308b9 into BabylonJS:master Jul 21, 2022
@carolhmj carolhmj deleted the SPS-bb-parameter branch August 19, 2022 13:53
RaananW pushed a commit that referenced this pull request Dec 9, 2022
Add computeBoundingBox as a constructor option on SPS.

Former-commit-id: 2ccdf0a58df15b3a2ffd93a9a0a774861ad1b09d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SPS should set the active mesh's bounding info to be the size of the SPS itself
2 participants