Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InputManager: Removed pointerup check that prevented event from being processed. #12800

Merged
merged 1 commit into from
Jul 26, 2022
Merged

InputManager: Removed pointerup check that prevented event from being processed. #12800

merged 1 commit into from
Jul 26, 2022

Conversation

PolygonalSun
Copy link
Contributor

During some testing, I found that there was a bug that was causing one of scene.onPointerObservable.notifyObservers calls to not be called if more than one button was pressed. This could be reproduced in Chromium, Firefox, and Safari browsers.

Basic Repro Steps:

  1. Open Basic PG
  2. Press left button, middle button, then right button (Do not let go of any of them)
  3. Release them in this order while moving around a bit (Right, Left, Middle)
  4. Now camera movement should be locked to your cursor movement

It should be noted that the DeviceSourceManager/DeviceInputSystem is still storing the correct values. This fix removes the check from the InputManager.

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

@PolygonalSun PolygonalSun merged commit 4b074f9 into BabylonJS:master Jul 26, 2022
RaananW pushed a commit that referenced this pull request Dec 9, 2022
#12800)

Former-commit-id: f35d048d5d9c7ab23f4a53f7bda15edb5a7ffece
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants