Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix is ready in a few scenari (light dirty, rendering pass id, material changes outside render loop) #12880

Merged
merged 4 commits into from
Aug 18, 2022

Conversation

sebavan
Copy link
Member

@sebavan sebavan commented Aug 18, 2022

No description provided.

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

Copy link
Contributor

@deltakosh deltakosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woot! that was a massive find!

Thansk a lot

@deltakosh deltakosh enabled auto-merge (squash) August 18, 2022 01:57
@azure-pipelines
Copy link

Visualization tests for webgl2 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12880/merge/testResults/webgl2/index.html

If tests were successful afterwards, this report might not be available anymore.

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

@azure-pipelines
Copy link

Visualization tests for webgl2 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12880/merge/testResults/webgl2/index.html

If tests were successful afterwards, this report might not be available anymore.

@azure-pipelines
Copy link

Visualization tests for webgl2 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12880/merge/testResults/webgl2/index.html

If tests were successful afterwards, this report might not be available anymore.

@RaananW
Copy link
Member

RaananW commented Aug 18, 2022

https://dev.azure.com/babylonjs/ContinousIntegration/_build/results?buildId=21531&view=logs&j=03cff698-595c-551b-40d3-439bc3cad69a&t=6c9fadb7-5ac5-5519-5354-f8d3dd7bbc46&l=5069 seems to be failing. Some err is outputed, but it is an object so firefox does right and outputs [Object object]. It didn't render at all, so there are no rendering diff HTMLs

@sebavan
Copy link
Member Author

sebavan commented Aug 18, 2022

Yup I am on it.

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

@deltakosh deltakosh merged commit 3295562 into BabylonJS:master Aug 18, 2022
RaananW pushed a commit that referenced this pull request Dec 9, 2022
Former-commit-id: 81dd5889007dc964d7381aa8c3ac7d11672b6988
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants