Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #13005 #13010

Merged
merged 1 commit into from
Sep 22, 2022
Merged

Fix #13005 #13010

merged 1 commit into from
Sep 22, 2022

Conversation

deltakosh
Copy link
Contributor

No description provided.

@deltakosh deltakosh enabled auto-merge (squash) September 22, 2022 16:29
Popov72
Popov72 approved these changes Sep 22, 2022
View reviewed changes
Copy link
Contributor

@Popov72 Popov72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was lightning fast!

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@deltakosh
Copy link
Contributor Author

That was lightning fast!

The power of meetings ;)

@azure-pipelines
Copy link

Snapshot stored with reference name:
refs/pull/13010/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13010/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13010/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/13010/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/13010/merge
https://gui.babylonjs.com/?snapshot=refs/pull/13010/merge
https://nme.babylonjs.com/?snapshot=refs/pull/13010/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/13010/merge#BCU1XR#0

@deltakosh deltakosh merged commit 4716a19 into master Sep 22, 2022
@deltakosh deltakosh deleted the Fix-13005 branch September 22, 2022 17:29
RaananW pushed a commit that referenced this pull request Dec 9, 2022
@deltakosh
Fix #13005 (#13010)
442ed4a 
Former-commit-id: 69f29b876946093a04b1d2b6d41255b4b58a9193
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Popov72 Popov72 Popov72 approved these changes

@sebavan sebavan sebavan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deltakosh @Popov72 @sebavan