Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix instance buffer #13021

Merged
merged 10 commits into from
Sep 26, 2022
Merged

Fix instance buffer #13021

merged 10 commits into from
Sep 26, 2022

Conversation

deltakosh
Copy link
Contributor

No description provided.

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

Snapshot stored with reference name:
refs/pull/13021/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13021/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13021/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/13021/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/13021/merge
https://gui.babylonjs.com/?snapshot=refs/pull/13021/merge
https://nme.babylonjs.com/?snapshot=refs/pull/13021/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/13021/merge#BCU1XR#0

@deltakosh deltakosh changed the title Fix instance buffer part1 Fix instance buffer Sep 23, 2022
@deltakosh deltakosh requested a review from Popov72 September 23, 2022 18:48
@sebavan sebavan merged commit 0fa67c9 into master Sep 26, 2022
@sebavan sebavan deleted the fix-instance-buffer-part1 branch September 26, 2022 00:08
RaananW pushed a commit that referenced this pull request Dec 9, 2022
@sebavan
Merge pull request #13021 from BabylonJS/fix-instance-buffer-part1
41998e9 
Fix instance buffer

Former-commit-id: e6701e4981a2de950cd31447017f63e5c0853cc9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebavan sebavan sebavan approved these changes

@CedricGuillemet CedricGuillemet Awaiting requested review from CedricGuillemet

@Popov72 Popov72 Awaiting requested review from Popov72

Assignees
No one assigned
Labels
bug rendering engine
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deltakosh @sebavan