correction #13031
correction #13031
Conversation
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Thanks for spotting this! |
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13031/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/13031/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/13031/merge#BCU1XR#0 |
|
https://playground.babylonjs.com/?snapshot=refs/pull/13031/merge#S7HDGQ#5 Still not correct, should be. Will need to double check before approval. This is what I based the change on and it works https://playground.babylonjs.com/#QYA3JC#32 |
|
I was wrong using TmpVectors.Vector3[0] instead of Vector3.Zero() is not always the right thing to do! Happy this works now https://playground.babylonjs.com/?snapshot=refs/pull/13031/merge#S7HDGQ#5 @RaananW can now merge after approving review. |
* correction * make ref 0 vector Former-commit-id: 3a67b52ab5098c05cd7569d10065886d3da75923
I did not check https://playground.babylonjs.com/?snapshot=refs/pull/13012/merge#S7HDGQ#5 before merge, the green axis should be tangential to the line and it was not. Should be OK after this PR
Reason for correction
PitchYawRollToMoveBetweenPointsToRef(start: Vector3, target: Vector3, ref: Vector3)
Cannot guarentee ref with be a zero vector and so need to make ref.z explicitly 0