Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InputManager: add a property to disable mesh checking in the onPointerOver event #13054

Merged
merged 4 commits into from
Oct 3, 2022
Merged

InputManager: add a property to disable mesh checking in the onPointerOver event #13054

merged 4 commits into from
Oct 3, 2022

Conversation

Popov72
Copy link
Contributor

@Popov72 Popov72 commented Oct 3, 2022

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

@azure-pipelines
Copy link

Visualization tests for webgl1 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13054/merge/testResults/webgl1/index.html

If tests were successful afterwards, this report might not be available anymore.

Copy link
Member

@sebavan sebavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flagging to prevent merge to check how that fits in with @PolygonalSun work ?

@sebavan
Copy link
Member

sebavan commented Oct 3, 2022

@PolygonalSun can you have a look at this PR to see if it does not conflict with your current work ?

@PolygonalSun
Copy link
Contributor

@PolygonalSun can you have a look at this PR to see if it does not conflict with your current work ?

It doesn't look like it'd conflict or, at the very least, doesn't look like it has any side effects that'd affect my current work negatively.

@sebavan sebavan merged commit 959a743 into BabylonJS:master Oct 3, 2022
RaananW pushed a commit that referenced this pull request Dec 9, 2022
InputManager: add a property to disable mesh checking in the onPointerOver event
Former-commit-id: 04e6e9339f689dd6c6fa815ca87c17b458c3674b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants