-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Depth of field optimizations and cleanup #13110
Conversation
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13110/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/13110/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/13110/merge#BCU1XR#0 |
Head branch was pushed to by a user without write access
Depth of field optimizations and cleanup Former-commit-id: 16da49e930014f56baa4f3c553d8ee49de0455c9
The main change here is to use R-only texture format for the circle of confusion (which only needs to store a single value per pixel) rather than using an RGBA texture. This will save space and should be more bandwidth efficient to sample from during the subsequent blur passes.
Also removes
sampleDistance
from the blur shader-- it's not used AFAICT and deleting this code removes the need for passing cameraMinMaxZ uniform.Other changes here are just minor cleanup.