NME: Fix and improve the HeightToNormal block #13171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
deltakosh
reviewed
Oct 26, 2022
packages/dev/core/src/Materials/Node/Blocks/Fragment/heightToNormalBlock.ts
Show resolved
Hide resolved
deltakosh
approved these changes
Oct 26, 2022
sebavan
approved these changes
Oct 26, 2022
RaananW
pushed a commit
that referenced
this pull request
Dec 9, 2022
NME: Fix and improve the HeightToNormal block Former-commit-id: f135868a43affcaac0c2a48dc591bd2c6434db7f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
position/normal/tangentinputs have been renamed toworldPosition/worldNormal/worldTangentand the oldoutputoutput has been renamedxyz(theoutputoutput is now a vec4).I didn't add code to keep back compat as this is a new block in 6.0 and probably few people have used it until now. Feel free to complain about this and I may revise my judgement :)
Note also that
worldNormalandworldTangentmust be normalized! I added two switches to allow for easy normalization for the user.The new "Generate in world space" mode allows to generate a normal which is directly usable as the
worldNormalinput of the PBRMetallicRoughness/Light block without the need for a PerturbNormal block.