Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support ClipPlanes in Materials #13249

Merged
merged 10 commits into from
Nov 16, 2022
Merged

Support ClipPlanes in Materials #13249

merged 10 commits into from
Nov 16, 2022

Conversation

sebavan
Copy link
Member

@sebavan sebavan commented Nov 15, 2022

Fix #13002

@sebavan sebavan requested a review from Popov72 November 15, 2022 21:29
@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

Snapshot stored with reference name:
refs/pull/13249/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13249/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13249/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/13249/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/13249/merge
https://gui.babylonjs.com/?snapshot=refs/pull/13249/merge
https://nme.babylonjs.com/?snapshot=refs/pull/13249/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/13249/merge#BCU1XR#0

@sebavan sebavan enabled auto-merge November 16, 2022 02:23
Popov72
Popov72 requested changes Nov 16, 2022
View reviewed changes
Copy link
Contributor

@Popov72 Popov72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition!

That was not such a small PR, afterall!

packages/dev/core/src/Layers/effectLayer.ts Outdated Show resolved Hide resolved
packages/dev/core/src/Layers/effectLayer.ts Outdated Show resolved Hide resolved
packages/dev/core/src/Lights/Shadows/shadowGenerator.ts Outdated Show resolved Hide resolved
packages/dev/core/src/Lights/Shadows/shadowGenerator.ts Show resolved Hide resolved
packages/dev/core/src/Materials/Node/Blocks/Dual/clipPlanesBlock.ts Outdated Show resolved Hide resolved
packages/dev/core/src/Rendering/outlineRenderer.ts Show resolved Hide resolved
packages/dev/core/src/Rendering/outlineRenderer.ts Outdated Show resolved Hide resolved
packages/dev/materials/src/cell/cellMaterial.ts Show resolved Hide resolved
packages/dev/materials/src/fire/fireMaterial.ts Show resolved Hide resolved
packages/dev/materials/src/fire/fireMaterial.ts Show resolved Hide resolved
@sebavan sebavan merged commit 361f105 into BabylonJS:master Nov 16, 2022
RaananW pushed a commit that referenced this pull request Dec 9, 2022
@sebavan
Merge pull request #13249 from sebavan/ClipPlanes
fdfc09e 
Support ClipPlanes in Materials

Former-commit-id: fe60153242f27371f74d1fb6e0371a089d4a9014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Popov72 Popov72 Popov72 approved these changes

Assignees
No one assigned
Labels
materials new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add clip planes support at the material level
2 participants
@sebavan @Popov72