Test babylon pbrmaterial #13268
Test babylon pbrmaterial #13268
Conversation
this test should check method part that enabling subSurfaceConfiguration
Simplify condition complexity
By some reasons this method don't return reflectivity texture when material has a metallic texture. And also method don't return metallic reflectance, reflectance, micro surface and refraction texture.
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13268/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/13268/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/13268/merge#BCU1XR#0 |
Maybe because they are not animatables? However, I don't know what means to have animations for a texture. Or we have simply forgotten to add those textures. What do you think @sebavan ? |
|
@Popov72 but all basic textures are animatable // packages/dev/core/src/Materials/Textures/baseTexture.ts
export class BaseTexture extends ThinTexture implements IAnimatable { |
|
I am working on something for @Popov72 comment :-) trying to merge getAnimatable and getActiveTextures code in some ways. Will PR soon-ish |
Test babylon pbrmaterial Former-commit-id: dba2c7a14ba05aa5f0127ee6730ad772b46d2852
Hi!
I made some test cases for PBRMaterial.
One strange point — the getAnimatables don't return all possilbe textures, such metallic reflectance, reflectance, micro surface and refraction texture. So I added a note to the method JSDoc, and comment to the test case.