Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test babylon scene materials #13285

Merged
merged 16 commits into from
Nov 25, 2022
Merged

Conversation

Dok11
Copy link
Contributor

@Dok11 Dok11 commented Nov 25, 2022

See #13277 from @sebavan
Here I added some tests for scene materials, note to the method, fix typos and simplify methods bodies.

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

@azure-pipelines
Copy link

Visualization tests for webgl1 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13285/merge/testResults/webgl1/index.html

If tests were successful afterwards, this report might not be available anymore.

@azure-pipelines
Copy link

Visualization tests for webgl2 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13285/merge/testResults/webgl2/index.html

If tests were successful afterwards, this report might not be available anymore.

packages/dev/core/src/scene.ts Outdated Show resolved Hide resolved
packages/dev/core/src/scene.ts Outdated Show resolved Hide resolved
@sebavan sebavan merged commit 5370aa8 into BabylonJS:master Nov 25, 2022
RaananW pushed a commit that referenced this pull request Dec 9, 2022
Test babylon scene materials

Former-commit-id: 7f93612cb4712a933df3f9d159e1dfee0da5f7af
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants