-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Texture rebuild on context lost #13299
Conversation
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13299/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/13299/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/13299/merge#BCU1XR#0 |
See https://forum.babylonjs.com/t/context-restore-for-textures-with-bloburl-not-working/36114, it seems it is not enough, the restored texture is Y inverted... |
One way to fix the problem is to remove this (in if (fromBlob && !this._doNotHandleContextLost) {
// We need to store the image if we need to rebuild the texture
// in case of a webgl context lost
texture._buffer = img;
} As Without removing this block of code I could not make it work. Currently, |
I ll have a look in a bit thanks for the feedback :-) |
Fix Texture rebuild on context lost Former-commit-id: ef8ac3bf0bbb8845a828d842aa981c2d3e5b3f47
https://forum.babylonjs.com/t/context-restore-for-textures-with-bloburl-not-working/36114