Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bad uniform scale check for rotation gizmo #13319

Merged
merged 2 commits into from
Dec 6, 2022
Merged

Fix bad uniform scale check for rotation gizmo #13319

merged 2 commits into from
Dec 6, 2022

Conversation

CedricGuillemet
Copy link
Contributor

fixes #13315

uniform scaling check was not taking negative component properly. Added a comment for future me.

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

@CedricGuillemet CedricGuillemet marked this pull request as ready for review December 6, 2022 13:16
@CedricGuillemet CedricGuillemet merged commit 2dbc75c into BabylonJS:master Dec 6, 2022
RaananW pushed a commit that referenced this pull request Dec 9, 2022
Fix bad uniform scale check for rotation gizmo

Former-commit-id: fb8ffe2e35ccd4e232bcfbafaa38c9f4814f6fd8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rotation gizmo does not work at all
3 participants