Rework Scene and GUI Editor connection #13353
Conversation
|
Snapshot available: Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13353/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/13353/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/13353/merge#BCU1XR#0 |
There was a problem hiding this comment.
Repeating something I said offline -
great work!
The only issue I see here is when you include images in your GUI. if an image URL is provided the image will be downloaded and decoded on every change, even when it's not the image that was updated.
This should be tracked in a different issue and resolved to allow a more efficient update of the ADT.
Currently, when a GUI Editor instance is opened through the Inspector, all existing controls on the Scene are removed and then re-added to both the "live" scene and the editor scene. This has been causing variety of problems, such as:
This PR introduces a new approach, such as when the editor is opened, the "live" scene's Controls are cloned and the clones added to the editor scene. Then, it periodically executes the opposite operation, cloning the editor controllers and adding them to the live scene.