Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for instanced meshes in STLEXPORT #13439

Merged
merged 1 commit into from
Jan 17, 2023

Conversation

d-0-s-t
Copy link
Contributor

@d-0-s-t d-0-s-t commented Jan 17, 2023

Related Forum Topic: https://forum.babylonjs.com/t/propose-to-remove-baking-transforms-during-stl-export-support-instanced-meshes/37210

CreateSTL has a new param "supportInstancedMeshes" which when set to true exports Instances without baking transforms on source mesh. Exporting instances with supportInstancedMeshes=false and doNotBakeTransforms=false may cause them to change orientation/positions in the scene.

CreateSTL has a new param "supportInstancedMeshes" which when set to true exports Instances without baking transforms on source mesh.
Exporting instances with supportInstancedMeshes=false and doNotBakeTransforms=false may cause them to change orientation/positions in the scene.
@bjsplat
Copy link
Collaborator

bjsplat commented Jan 17, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@d-0-s-t
Copy link
Contributor Author

d-0-s-t commented Jan 17, 2023

Can't figure out how to add label to this PR. I thought I missed something the first time but can't see an option. Maybe I don't have permission?

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 17, 2023

Copy link
Member

@RaananW RaananW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
@sebavan ?

@sebavan sebavan merged commit cebcfb3 into BabylonJS:master Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants