Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Physics Iteration 5 #13498

Merged
merged 12 commits into from
Feb 7, 2023
Merged

Conversation

CedricGuillemet
Copy link
Contributor

@CedricGuillemet CedricGuillemet commented Feb 3, 2023

There is an issue with impulse/force that will be fixed in next iteration.
Aggregate is starting working just like impostors
PhysicsHelper moved from V1 to parent path

@bjsplat
Copy link
Collaborator

bjsplat commented Feb 3, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Feb 3, 2023

@bjsplat
Copy link
Collaborator

bjsplat commented Feb 3, 2023

Visualization tests for webgl2 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13498/merge/testResults/webgl2/index.html

If tests were successful afterwards, this report might not be available anymore.

@CedricGuillemet CedricGuillemet marked this pull request as ready for review February 6, 2023 11:06
Copy link
Member

@RaananW RaananW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nits and build issue, otherwise LGTM :-)

packages/dev/core/src/Physics/v2/physicsAggregate.ts Outdated Show resolved Hide resolved
packages/dev/core/src/Physics/physicsHelper.ts Outdated Show resolved Hide resolved
packages/dev/core/src/Physics/v2/physicsAggregate.ts Outdated Show resolved Hide resolved
Co-authored-by: Carolina <carolhmj@gmail.com>
@bjsplat
Copy link
Collaborator

bjsplat commented Feb 6, 2023

Visualization tests for webgl2 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13498/merge/testResults/webgl2/index.html

If tests were successful afterwards, this report might not be available anymore.

packages/dev/core/src/Physics/physicsHelper.ts Outdated Show resolved Hide resolved
packages/dev/core/src/Physics/physicsHelper.ts Outdated Show resolved Hide resolved
packages/dev/core/src/Physics/physicsHelper.ts Outdated Show resolved Hide resolved
packages/dev/core/src/Physics/physicsHelper.ts Outdated Show resolved Hide resolved
packages/dev/core/src/Physics/physicsHelper.ts Outdated Show resolved Hide resolved
packages/dev/core/src/Physics/physicsHelper.ts Outdated Show resolved Hide resolved
packages/dev/core/src/Physics/physicsHelper.ts Outdated Show resolved Hide resolved
@bjsplat
Copy link
Collaborator

bjsplat commented Feb 7, 2023

Visualization tests for webgl1 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13498/merge/testResults/webgl1/index.html

If tests were successful afterwards, this report might not be available anymore.

2 similar comments
@bjsplat
Copy link
Collaborator

bjsplat commented Feb 7, 2023

Visualization tests for webgl1 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13498/merge/testResults/webgl1/index.html

If tests were successful afterwards, this report might not be available anymore.

@bjsplat
Copy link
Collaborator

bjsplat commented Feb 7, 2023

Visualization tests for webgl1 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13498/merge/testResults/webgl1/index.html

If tests were successful afterwards, this report might not be available anymore.

@bjsplat
Copy link
Collaborator

bjsplat commented Feb 7, 2023

Visualization tests for webgl1 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13498/merge/testResults/webgl1/index.html

If tests were successful afterwards, this report might not be available anymore.

@bjsplat
Copy link
Collaborator

bjsplat commented Feb 7, 2023

Visualization tests for webgl1 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13498/merge/testResults/webgl1/index.html

If tests were successful afterwards, this report might not be available anymore.

@CedricGuillemet CedricGuillemet merged commit d32a1f3 into BabylonJS:master Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants