Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebGPU: Fix engine initialization #13541

Merged
merged 1 commit into from
Feb 16, 2023
Merged

WebGPU: Fix engine initialization #13541

merged 1 commit into from
Feb 16, 2023

Conversation

Popov72
Copy link
Contributor

@Popov72 Popov72 commented Feb 15, 2023

Close #13488.

@bjsplat
Copy link
Collaborator

bjsplat commented Feb 15, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Feb 15, 2023

Snapshot stored with reference name:
refs/pull/13541/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13541/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13541/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/13541/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/13541/merge
https://gui.babylonjs.com/?snapshot=refs/pull/13541/merge
https://nme.babylonjs.com/?snapshot=refs/pull/13541/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/13541/merge#BCU1XR#0

@sebavan sebavan requested a review from RaananW February 15, 2023 19:57
RaananW
RaananW approved these changes Feb 16, 2023
View reviewed changes
Copy link
Member

@RaananW RaananW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! just a small question

packages/dev/core/src/Engines/thinEngine.ts Show resolved Hide resolved
@RaananW RaananW merged commit a818869 into BabylonJS:master Feb 16, 2023
@Popov72 Popov72 deleted the webgpu-fix-init branch April 20, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaananW RaananW RaananW approved these changes

@sebavan sebavan sebavan approved these changes

Assignees
No one assigned
Labels
bug WebGPU
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WebGPU: fix engine initialization
4 participants
@Popov72 @bjsplat @RaananW @sebavan