Fix typos #13571

Lioness100 · 2023-02-28T15:42:28Z

This PR fixes a few typos throughout the repository. I noticed a few typos that were either part of public APIs, or that I didn't know what they should be corrected to:

SimplicationQueueSceneComponent: should be SimplificationQueueSceneComponent, but it looks public
recordChunckSize: should be recordChunkSize, but it looks public
volumetricLightMergePostProces: should be volumetricLightMergePostProcess, but it looks public
supressXRSelectEvents: should be suppressXRSelectEvents, but it looks public
disableSpecatatorMode: should be disableSpectatorMode, but it looks public
dipose: should be dispose, but it looks public
diffuseTexturY: should be diffuseTextureY. This is from the following code:

    @serializeAsTexture("diffuseTexturY")
    private _diffuseTextureY: BaseTexture;

The typo is only in the decorator, so I don't know if changing it would be breaking.

locatRect: located here. I don't know if this spelling is correct, or if it should be localRect, or maybe locateRect?
surexposed: located here, not sure if it's a typo
rewrited: located here. I don't really understand the intent of the sentence due to some grammar issues, so I'm not sure the best way to fix it.
Wwves: located here. Should this be "Waves"?
onFullcreenRequiredObservable: should be onFullscreenRequiredObservable, but it looks public
onEditorFullcreenRequiredObservable: onEditorFullscreenRequiredObservable, but it looks public
shadown: located in a few places, is this a typo? Maybe for shadow or shadows?
shadowSpotlLightConfiguration: I think it should be shadowSpotlightConfiguration, but it looks public
SphericalPolynomalCoefficients: should be SphericalPolynomialCoefficients, but it looks public
rotatquatRotationY: is this a typo?

bjsplat · 2023-02-28T15:43:53Z

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

bjsplat · 2023-02-28T15:43:55Z

There is no need to update the "what's new.md" file. A changelog will be generated using the PR and its tags.

bjsplat · 2023-02-28T15:45:18Z

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

bjsplat · 2023-02-28T15:45:20Z

There is no need to update the "what's new.md" file. A changelog will be generated using the PR and its tags.

bjsplat · 2023-02-28T15:52:42Z

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

RaananW

Wow, what an awesome PR. Love it! :-)

I found a few public API changes that should be proxied - a deprecated getter would be the best. Otherwise - this is amazing.

RaananW · 2023-02-28T16:10:33Z

packages/dev/gui/src/2D/controls/displayGrid.ts

+ public get minorLineThickness(): number {
+ return this._minorLineThickness;
 }

- public set minorLineTickness(value: number) {
- this._minorLineTickness = value;
+ public set minorLineThickness(value: number) {
+ this._minorLineThickness = value;


Wheereas I totally agree that this is a typo and should be fixed, this is a breaking change. We will need to add a (deprecated) proxy to support the old syntax

RaananW · 2023-02-28T16:10:44Z

packages/dev/gui/src/2D/controls/displayGrid.ts

+ public get majorLineThickness(): number {
+ return this._majorLineThickness;
 }

- public set majorLineTickness(value: number) {
- this._majorLineTickness = value;
+ public set majorLineThickness(value: number) {
+ this._majorLineThickness = value;


Same as above

RaananW · 2023-02-28T16:11:06Z

packages/dev/gui/src/3D/materials/mrdl/mrdlSliderBarMaterial.ts

@@ -460,7 +460,7 @@ export class MRDLSliderBarMaterial extends PushMaterial {
 /**
 * @internal
 */
- public globaRightIndexTipPosition = new Vector4(0.0, 0.0, 0.0, 1.0);
+ public globalRightIndexTipPosition = new Vector4(0.0, 0.0, 0.0, 1.0);


back-compat

RaananW · 2023-02-28T16:11:24Z

packages/dev/gui/src/2D/controls/inputText.ts

+ public get highlighterOpacity(): number {
+ return this._highlighterOpacity;
 }

- public set highligherOpacity(value: number) {
- if (this._highligherOpacity === value) {
+ public set highlighterOpacity(value: number) {


back-compat

packages/dev/gui/src/3D/materials/mrdl/mrdlSliderThumbMaterial.ts

bjsplat · 2023-02-28T16:21:02Z

Snapshot stored with reference name:
refs/pull/13571/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13571/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13571/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/13571/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/13571/merge
https://gui.babylonjs.com/?snapshot=refs/pull/13571/merge
https://nme.babylonjs.com/?snapshot=refs/pull/13571/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/13571/merge#BCU1XR#0

RaananW · 2023-02-28T16:21:20Z

This PR fixes a few typos throughout the repository. I noticed a few typos that were either part of public APIs, or that I didn't know what they should be corrected to:

SimplicationQueueSceneComponent: should be SimplificationQueueSceneComponent, but it looks public

Public, I would rather not change it. But you are right :-)

recordChunckSize: should be recordChunkSize, but it looks public

Same. As for all public APIs - either we define a deprecated getter for them (in case of members or getters), or sadly leave them as they are

dipose: should be dispose, but it looks public

we have a dipose function somewhere? this would feel like a bug.

diffuseTexturY: should be diffuseTextureY. This is from the following code:
    @serializeAsTexture("diffuseTexturY")
    private _diffuseTextureY: BaseTexture;
The typo is only in the decorator, so I don't know if changing it would be breaking.

I would consider that a bug - we should change that.

locatRect: located here. I don't know if this spelling is correct, or if it should be localRect, or maybe locateRect?

should be local

surexposed: located here, not sure if it's a typo

rewrited: located here. I don't really understand the intent of the sentence due to some grammar issues, so I'm not sure the best way to fix it.

is rewritten, instead of be rewrited. But I think the 2nd half of the sentence is not really needed TBH. Keep it as is for now.

Wwves: located here. Should this be "Waves"?

Waves for sure :-)

shadown: located in a few places, is this a typo? Maybe for shadow or shadows?

Shadows, probably. depending on the context.

rotatquatRotationY: is this a typo?

is this public? yes - this must be a typo

Lioness100 · 2023-02-28T18:05:36Z

we have a dipose function somewhere? this would feel like a bug.

Babylon.js/packages/dev/gui/src/2D/controls/inputTextArea.ts

Line 1224 in 0505575

public dipose() {

Shadows, probably. depending on the context.

Babylon.js/packages/tools/viewer/src/configuration/interfaces/lightConfiguration.ts

Line 13 in 0505575

shadownEnabled?: boolean; // only on specific lights!

Babylon.js/packages/tools/viewer/src/managers/sceneManager.ts

Line 1386 in 0505575

const shadownMap = shadowGenerator.getShadowMap();

is this public? yes - this must be a typo

No, it's a local variable name.

Babylon.js/packages/tools/viewer/src/labs/viewerLabs.ts

Line 129 in 0505575

const rotatquatRotationionY = Quaternion.RotationAxis(Axis.Y, rotationY || 0);

Babylon.js/packages/tools/viewer/src/managers/sceneManager.ts

Line 874 in 0505575

 const rotatquatRotationionY = Quaternion.RotationAxis(Axis.Y, environmentMapConfiguration.rotationY || 0); 

RaananW · 2023-02-28T19:22:28Z

we have a dipose function somewhere? this would feel like a bug.

Babylon.js/packages/dev/gui/src/2D/controls/inputTextArea.ts

Line 1224 in 0505575

public dipose() {

Shadows, probably. depending on the context.

Babylon.js/packages/tools/viewer/src/configuration/interfaces/lightConfiguration.ts

Line 13 in 0505575

shadownEnabled?: boolean; // only on specific lights!

Babylon.js/packages/tools/viewer/src/managers/sceneManager.ts

Line 1386 in 0505575

const shadownMap = shadowGenerator.getShadowMap();

is this public? yes - this must be a typo

No, it's a local variable name.

Babylon.js/packages/tools/viewer/src/labs/viewerLabs.ts

Line 129 in 0505575

const rotatquatRotationionY = Quaternion.RotationAxis(Axis.Y, rotationY || 0);

Babylon.js/packages/tools/viewer/src/managers/sceneManager.ts

Line 874 in 0505575

const rotatquatRotationionY = Quaternion.RotationAxis(Axis.Y, environmentMapConfiguration.rotationY || 0);

oh, all of these can be changed :-)
dispose (a bug), shadowsEnabled (a bug), shadowsMap, quaternionRotationY

RaananW · 2023-02-28T19:22:50Z

And once again, thank you so much for all the time invested in this!

Lioness100 · 2023-03-02T02:19:24Z

No problem! A bit busy atm, but I'll try to make the new changes within the next few days.

RaananW · 2023-03-14T12:26:44Z

Moving this to draft for the time being, will move it back when you have the time :-)

sebavan · 2023-06-01T17:36:59Z

@Lioness100 do you have any updates on this PR ?

sebavan · 2023-06-14T15:33:11Z

Closing for now and let s reopen if it gets updated.

Lioness100 added 2 commits February 28, 2023 10:25

Fix typos

f8e0c0b

didn't mean to commit that

9d650bb

revert what's new

0d16a33

RaananW reviewed Feb 28, 2023

View reviewed changes

RaananW marked this pull request as draft March 14, 2023 12:26

sebavan closed this Jun 14, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix typos #13571

Fix typos #13571

Lioness100 commented Feb 28, 2023

bjsplat commented Feb 28, 2023

bjsplat commented Feb 28, 2023

bjsplat commented Feb 28, 2023

bjsplat commented Feb 28, 2023

bjsplat commented Feb 28, 2023

RaananW left a comment

RaananW Feb 28, 2023

RaananW Feb 28, 2023

RaananW Feb 28, 2023

RaananW Feb 28, 2023

bjsplat commented Feb 28, 2023

RaananW commented Feb 28, 2023

Lioness100 commented Feb 28, 2023 •

edited

Loading

RaananW commented Feb 28, 2023

RaananW commented Feb 28, 2023

Lioness100 commented Mar 2, 2023

RaananW commented Mar 14, 2023

sebavan commented Jun 1, 2023

sebavan commented Jun 14, 2023

Fix typos #13571

Fix typos #13571

Conversation

Lioness100 commented Feb 28, 2023

bjsplat commented Feb 28, 2023

bjsplat commented Feb 28, 2023

bjsplat commented Feb 28, 2023

bjsplat commented Feb 28, 2023

bjsplat commented Feb 28, 2023

RaananW left a comment

Choose a reason for hiding this comment

RaananW Feb 28, 2023

Choose a reason for hiding this comment

RaananW Feb 28, 2023

Choose a reason for hiding this comment

RaananW Feb 28, 2023

Choose a reason for hiding this comment

RaananW Feb 28, 2023

Choose a reason for hiding this comment

bjsplat commented Feb 28, 2023

RaananW commented Feb 28, 2023

Lioness100 commented Feb 28, 2023 • edited Loading

RaananW commented Feb 28, 2023

RaananW commented Feb 28, 2023

Lioness100 commented Mar 2, 2023

RaananW commented Mar 14, 2023

sebavan commented Jun 1, 2023

sebavan commented Jun 14, 2023

Lioness100 commented Feb 28, 2023 •

edited

Loading