Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PointerDragBehavior: Added check to force releaseDrag to fire when no active button is present #13578

Merged
merged 1 commit into from
Mar 1, 2023

Conversation

PolygonalSun
Copy link
Contributor

A user on the forum found an issue where if a user programmatically started a drag event, they could not release it with a click. Using their provided solution, this PR contains the following fix. A check was added to the POINTERUP section to just force the release if there is no active button (thanks to mattdmorgan for the fix recommendation).

Forum Link: https://forum.babylonjs.com/t/programmatically-started-drags-can-no-longer-be-completed-by-clicking/38228

@bjsplat
Copy link
Collaborator

bjsplat commented Mar 1, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Mar 1, 2023

@PolygonalSun PolygonalSun merged commit b3fb7e9 into BabylonJS:master Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants