Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InputManager: Modified Logic for ExclusiveDoubleClickMode For Click/DoubleClick Mutual Exclusivity #13582

Merged
merged 3 commits into from
Mar 10, 2023

Conversation

PolygonalSun
Copy link
Contributor

In a previous PR, there was a fix done to the logic for handling the ExclusiveDoubleClickMode flag to omit single clicks when this flag was active. This fix was done in error based off of a misinterpretation of the original comment for the flag. This PR fixes the logic and further clarifies the full behavior when this flag is active. Test has also been updated to properly test this.

Previous PR: #13577

@bjsplat
Copy link
Collaborator

bjsplat commented Mar 2, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@PolygonalSun PolygonalSun marked this pull request as draft March 2, 2023 23:10
@bjsplat
Copy link
Collaborator

bjsplat commented Mar 2, 2023

Copy link
Member

@RaananW RaananW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the right behavior now. why is this in draft?

@PolygonalSun
Copy link
Contributor Author

Looks like the right behavior now. why is this in draft?

It still doesn't work right, with respect to multiple different button presses (eg. double left-click then single right-click)

@PolygonalSun PolygonalSun requested a review from RaananW March 8, 2023 23:05
@PolygonalSun PolygonalSun marked this pull request as ready for review March 8, 2023 23:05
Copy link
Member

@RaananW RaananW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two comments :-)

packages/dev/core/src/Inputs/scene.inputManager.ts Outdated Show resolved Hide resolved
packages/dev/core/src/Inputs/scene.inputManager.ts Outdated Show resolved Hide resolved
@RaananW RaananW merged commit aa9b0b2 into BabylonJS:master Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants