Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of texture names in glTF loader #15709

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

bghgary
Copy link
Contributor

@bghgary bghgary commented Oct 17, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 17, 2024

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 17, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 17, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 17, 2024

@bghgary
Copy link
Contributor Author

bghgary commented Oct 17, 2024

@Popov72 @sebavan I've update the PR with some code to serialize the label property but it's not perfect because the code is storing the label of InternalTexture on Texture instead since we don't serialize InternalTexture. This has potential for conflicts and more bytes serialized than necessary, but it's unlikely to cause a problem.

@bghgary bghgary marked this pull request as ready for review October 17, 2024 20:12
@bghgary bghgary merged commit b9c17a2 into BabylonJS:master Oct 17, 2024
10 of 12 checks passed
@bghgary bghgary deleted the gltf-texture-name branch October 17, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants