Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip frustum clipping in viewer #15740

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

ryantrem
Copy link
Member

I recently removed the code that was setting performancePriority to Aggressive because it broke some rendering scenarios (still investigating). However removing it also breaks other things. Specifically, we need to skip frustum culling (render all meshes) for WebGPU snapshot mode. So I'm adding this back explicitly (along with one other performancePriority related setting) for now. Also I updated the published.html test file to use jsdelivr instead of unpkg as it is faster and easier to use when testing.

@ryantrem ryantrem enabled auto-merge (squash) October 25, 2024 21:42
@bjsplat
Copy link
Collaborator

bjsplat commented Oct 25, 2024

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 25, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 25, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 25, 2024

@ryantrem ryantrem merged commit 650c1f7 into BabylonJS:master Oct 25, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants