-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Needed changes to enable the inspector on the viewer #15780
Conversation
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good but one tiny neat, would be cool to be able to align our build tech :-)
Yea I was thinking about this as well. If having Vite and Rollup mixed in is potentially going to cause more future pain, maybe we need to revisit this conversation sooner than later. Main issue is I could not find any way to create an ES bundle with WebPack. I'm not sure if Vite/Rollup can/should replace all our WebPack usage either. |
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15780/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/15780/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/15780/merge#BCU1XR#0 |
WebGL2 visualization test reporter: |
Visualization tests for WebGPU (Experimental) |
Move showInspector from Viewer to ViewerElement
Remove changes attempting to get inspector bundling with the viewer dist
Added the ability to toggle the inspector in the viewr alpha test app.
A few notes:
These changes actually allow the inspector to be released as a standalone es6 module (i.e. - not bundled). As this can be considered a breaking change I did not include it in this PR. we can discuss it in the future. for now no change was made to break anything.
EDIT from @ryantrem:
showInspector
function from the viewer element.We can circle back to the inspector integration later and try to get it included as a feature, particularly if we think it is important to have it work with the viewer distribution bundle. At least now with these changes if both the viewer and the inspector are consumed by an app being build/bundled, inspector will work with the viewer.