-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Viewer loading progress bar #15784
Viewer loading progress bar #15784
Conversation
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15784/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/15784/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/15784/merge#BCU1XR#0 |
WebGL2 visualization test reporter: |
Visualization tests for WebGPU (Experimental) |
This PR adds a default loading progress bar. The styling can be customized (via CSS variables for things like color or the progress-bar part for things like height, border radius, etc.) or completely replaced with custom UI (via the progress-bar slot). For cases where we don't know the size of the download, it is a simple indeterminate progress bar.
Currently this is only for model source download, it does not take into account environment texture download. I think we should probably bring this in as well, but it requires more changes to core. Open to thoughts though.
Screen.Recording.2024-11-06.164053.mp4