Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viewer loading progress bar #15784

Merged
merged 11 commits into from
Nov 7, 2024
Merged

Conversation

ryantrem
Copy link
Member

@ryantrem ryantrem commented Nov 7, 2024

This PR adds a default loading progress bar. The styling can be customized (via CSS variables for things like color or the progress-bar part for things like height, border radius, etc.) or completely replaced with custom UI (via the progress-bar slot). For cases where we don't know the size of the download, it is a simple indeterminate progress bar.

Currently this is only for model source download, it does not take into account environment texture download. I think we should probably bring this in as well, but it requires more changes to core. Open to thoughts though.

Screen.Recording.2024-11-06.164053.mp4

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 7, 2024

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 7, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 7, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 7, 2024

@ryantrem ryantrem enabled auto-merge (squash) November 7, 2024 01:34
packages/tools/viewer-alpha/src/viewerElement.ts Outdated Show resolved Hide resolved
packages/tools/viewer-alpha/src/viewer.ts Show resolved Hide resolved
@ryantrem ryantrem merged commit ae0d771 into BabylonJS:master Nov 7, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants