Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add speed and delay to camera auto orbit config/props #15789

Merged
merged 3 commits into from
Nov 13, 2024

Conversation

ryantrem
Copy link
Member

@ryantrem ryantrem commented Nov 7, 2024

This PR adds the ability to set the camera auto orbit delay and speed (as discussed here: https://forum.babylonjs.com/t/babylon-viewer-v2/54317/33).

After some discussion with @sebavan we're trying out grouping related properties together at the JS layer to reduce API surface area explosion, so I applied this pattern to tone mapping + contrast + exposure as well.

@ryantrem ryantrem requested review from RaananW and sebavan November 7, 2024 23:12
@bjsplat
Copy link
Collaborator

bjsplat commented Nov 7, 2024

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 7, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 7, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 7, 2024

@ryantrem ryantrem marked this pull request as ready for review November 13, 2024 05:40
@ryantrem ryantrem enabled auto-merge (squash) November 13, 2024 05:40
@RaananW
Copy link
Member

RaananW commented Nov 13, 2024

Putting this PR in draft

Did you mean to enable auto-merge?

@ryantrem
Copy link
Member Author

ryantrem commented Nov 13, 2024

Putting this PR in draft

Did you mean to enable auto-merge?

Yes I just forgot to update the description when I took it out of draft. The changes here are based on some feedback from @sebavan.

@ryantrem ryantrem merged commit 2728883 into BabylonJS:master Nov 13, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants