Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support to mimetype autodetection #15798

Merged
merged 8 commits into from
Nov 11, 2024
Merged

Adding support to mimetype autodetection #15798

merged 8 commits into from
Nov 11, 2024

Conversation

deltakosh
Copy link
Contributor

@deltakosh deltakosh commented Nov 8, 2024

This feature adds support from automatic mime type discovery which was missing

I was reluctant at first (#15793) because it introduces a breaking change.

That being said it is really unlikely that someone would make any use of what was returned.
I also started to add support for fetch (indirectly) as this is something we want to do.

Finally I flagged the non async functions as deprecated to help move user codebase

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 8, 2024

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 8, 2024

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 8, 2024

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@deltakosh deltakosh closed this Nov 8, 2024
@deltakosh deltakosh reopened this Nov 8, 2024
@bjsplat
Copy link
Collaborator

bjsplat commented Nov 8, 2024

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 8, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 8, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 8, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 8, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 8, 2024

Visualization tests for WebGL 1 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15798/merge/testResults/webgl1/index.html

If tests were successful afterwards, this report might not be available anymore.

@deltakosh
Copy link
Contributor Author

Waiting for the vote here to finish to decide if we merge or not: https://forum.babylonjs.com/t/potential-new-breaking-change-please-chime-in/54651/1

@deltakosh deltakosh merged commit c0a6783 into master Nov 11, 2024
12 checks passed
@deltakosh deltakosh deleted the mime branch November 11, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants